Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Edit truffle unbox #1471

Merged
merged 7 commits into from
Dec 4, 2018
Merged

Edit truffle unbox #1471

merged 7 commits into from
Dec 4, 2018

Conversation

eggplantzzz
Copy link
Contributor

@eggplantzzz eggplantzzz commented Nov 27, 2018

Reorganize truffle unbox and move cleanup phase so that it happens before copying files from the temp dir.

This work was inspired by and resolves issue #1456

Also add some fancy spinners to the unboxing terminal output

@coveralls
Copy link

coveralls commented Nov 27, 2018

Coverage Status

Coverage decreased (-0.03%) to 67.535% when pulling ea37f57 on edit-unbox into 6c258fb on next.

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eggplantzzz eggplantzzz closed this Dec 4, 2018
@eggplantzzz eggplantzzz reopened this Dec 4, 2018
@eggplantzzz eggplantzzz merged commit 17b8b81 into next Dec 4, 2018
@CruzMolina CruzMolina deleted the edit-unbox branch December 4, 2018 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants